[expo-updates][Android] Prevent emergency launch after request header override - #49732
Open
roitium wants to merge 2 commits into
Open
[expo-updates][Android] Prevent emergency launch after request header override#49732roitium wants to merge 2 commits into
roitium wants to merge 2 commits into
Conversation
overriding update request headers at runtime.
Contributor
|
Subscribed to pull request
Generated by CodeMention |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Runtime update request-header overrides using
Updates.setUpdateRequestHeadersOverride(requestHeaders)can prevent the embedded update from matching the effective configuration on a later cold start, causing an unnecessary emergency launch.How
Keep the normal selection policy unchanged. When it finds no matching update, fall back only to the update embedded in the current binary.
Test Plan
I applied this patch to my app's expo-updates; it compiled successfully, and the bug got fixed.
Checklist
changelog.mdentry and rebuilt the package sources according to this short guidenpx expo prebuild& EAS Build (eg: updated a module plugin).